fix(net): stop classifying casks from redirect chains the download would reject - #880
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The HEAD walk that classifies a cask artifact resolved one redirect further
than the download could follow. A cask URL behind exactly that many redirects
classified successfully - possibly as
.pkg, which raises the system-widesudo installer -target /prompt - and then always failed at download. Noinstall that works today changes; the password prompt just stops being raised
for a download that provably cannot complete.
The budgets disagreed because each of the three redirect walks kept its own
copy of the rules. They now share one decision, so this class of drift - four
instances so far - closes by construction rather than by hand.
Related Issue
Notes for Reviewers
are re-pointed at the shared decision; their fixtures are unchanged.